Bug report in audio module (with fix)

[Stephan]

Hi There,

 

Today I was working on the new examples for the Panda.js Fiddler and noticed a small bug in the audio module.

    setMusicVolume: function(value) {        if (!game.Audio.enabled) return false;        this.musicVolume = value;        if (!this.currentMusic) return false;        if (this.context) {            this.currentMusic.gainNode.gain.value = this.musicVolume;   //ERROR!        }        else {            this.currentMusic.volume = this.musicVolume;        }        return true;    },

this.currentMusic.gainNode.gain.value = this.musicVolume;

should be: 

this.audioObjects[this.currentMusic].gainNode.gain.value = this.musicVolume;

 

 

@Enpu: Which way do you prefer to receive bugreports? (I have little experience with github yet so that's why I post this bug over here  ).

Stephan 

 

[enpu]

Hi Stephan!

 

Thanks for the fix. Github would be the best way to receive issues/pull requests, but this is also ok.

This should be now fixed on develop branch

[Stephan]

Ok, next time I will give Github a try if I dare. 

[Stephan]

Hi Enpu, I just found another small error and I made my first pull request on github. It is my first time using Github so let me know if I did something wrong...