Mesh.setVerticesData 1.12 signature

[JCPalmer]

Hey,

Saw in 'what's new.md':

Mesh.setVerticesData signature is now: (kind, values, updatable) instead of (values, kind, updatable) in order to be consistent with Mesh.updateVerticesData

 

 

In my Towel of Babel, I was still doing it the old way.  No problem, I move a few lines of python code.  Was wondering though: might be even better if values was last.  When looking at the in-line .js with wrap turned off,  it would be a little nicer to be able to have the kind, and updateable on the left & values trail off to the right.

 

Not a big deal if causes issues.

 

Jeff

[JCPalmer]

As a corollary,  is the version of Babylon callable in JS?  I might want to put in min version checking into the generated .js.  Might get old telling people over & over again "Your version of Babylon is too old", after they cannot get it to run & wasted lots of time debugging.

[JCPalmer]

looking around, I do not see any version. (1.13 please).  Have I check that should work.  Have not tried yet, but have put it in a python var since it needs to be put at every entry point:

 

    versionCheckCode = "\tif (typeof(scene.beforeCameraRender) != \"function\") {\n\t\tconsole.log('Babylon version too old');\n\t\treturn;\n\t}"
 

 

Any other suggestions?

[JCPalmer]

Well found the old arg order is just depreciated, so for now I'll make it work for 1.11 & 1.12 .  That check did not work anyway.  It is a callback not a function in scene.  Hopefully, version checking can be put in the future, BEFORE IT IS NEEDED.

[GameMonetize]

1.13 will add a version info

[Dad72]

What is the difference between version 1.12 and 1.13 version. the 2 version is the difference?

I tested version 1.13 and the scene is entirely white.

[JCPalmer]

dad72,

Are saying the parameter order is mandatory in 1.13 ?  If so, having a reported version is definitely required for 1.13. The syntax for the test would have to be something like this, since 1.12 had no version reporting:

 

if (typeof(scene.getVersion) === function  && scene.getVersion() >= 1.13)

[Dad72]

ok, thanks, but the scene is entirely white with version 1.13

[GameMonetize]

v1.13 == v.12 no change for now except the version number

[GameMonetize]

Do you have errors in the console?

[Dad72]

No, no error in the console. When I use again 1.12 my scene it loads correctly.

[GameMonetize]

example?

[Dad72]

I took the scene worldMonger that recreate the problem :
 
Exemple scene

[Dad72]

I've updated with the last change in the 1.13 on my link above. If manipulate you \"Quality\" the scene appears, ok, but if Quality is max, the scene is still all white.

[GameMonetize]

I'm sorry but this works perfectly well for me

[Dad72]

actually. I had to be on the covers. It works now.