BABYLON.VertexBuffer.prototype.update bug?

[gwenael]

Hi,

 

I was wondering if a test was not missing in this function. Here's its current implementation:

BABYLON.VertexBuffer.prototype.update = function (data) {        this._engine.updateDynamicVertexBuffer(this._buffer, data);        this._data = data;                if (this._kind === BABYLON.VertexBuffer.PositionKind && this._mesh) {            this._mesh._resetPointsArrayCache();        }    };

and here's how I think it should be:

BABYLON.VertexBuffer.prototype.update = function (data) {        if(!this._updatable) {            return;        }        this._engine.updateDynamicVertexBuffer(this._buffer, data);        this._data = data;                if (this._kind === BABYLON.VertexBuffer.PositionKind && this._mesh) {            this._mesh._resetPointsArrayCache();        }    };

Or a new parameter 'force' could be used as is:

BABYLON.VertexBuffer.prototype.update = function (data, force) {        if(!this._updatable && !force) {            return;        }        this._engine.updateDynamicVertexBuffer(this._buffer, data);        this._data = data;                if (this._kind === BABYLON.VertexBuffer.PositionKind && this._mesh) {            this._mesh._resetPointsArrayCache();        }    };

In this case, should '_updatable' be set to true when force equals true?

[GameMonetize]

You're right here is the new version:

public update(data: number[]): void {            if (!this._updatable) {                console.log("You cannot update a non-updatable vertex buffer");                return;            }            this._engine.updateDynamicVertexBuffer(this._buffer, data);            this._data = data;            if (this._kind === BABYLON.VertexBuffer.PositionKind && this._mesh) {                this._mesh._resetPointsArrayCache();            }        }

[gwenael]

Ok. I will check if it's what I did in my code for geometry instances. Coming soon...

[GameMonetize]

Please wait for the typescript version before

[gwenael]

No problem. I'll send you a link to my fork/branch first so you could check the code and see if I need to rename stuff, do stuff differently and so on and then, once typescript version is ready I'll do the pull-request.

[gwenael]

BTW, geometry instances would be really useful for a LOD system, did you start working on it? I could already modify my code to foresee its integration.

[gwenael]

Or even start working on the LOD system.

[GameMonetize]

Not started so feel free (a lot of typescript is already done btw)