Dan K Posted March 9, 2019 Share Posted March 9, 2019 I think you should change the property isKinematic to "blockEvents" to embody the scope and purpose of this variable. I know its linked collisions and I suspect that's why it was chosen. But even if the programmer is looking at the collisions aspect of the Renderable, I think the blockEvents will catch their eye and their mind will consider 'collisionEvents' blocked by the changing of this term. Quote Link to comment Share on other sites More sharing options...
obiot Posted March 11, 2019 Share Posted March 11, 2019 thanks for the feedback, but coming from the Unity word, isKinematic is kind of well know as they define the same property. Now admittedly the use of isKinematic has been slightly abused in melonJS to also apply to pointer event as well (if this is what you mean), where it should be limited to physic interactions/motions. Quote Link to comment Share on other sites More sharing options...
Dan K Posted March 11, 2019 Author Share Posted March 11, 2019 If it was limited to those physic interactions then I agree... The name seems appropriate... But the fact that it blocked the events surprised me. However, it was in the documentation so that is on me of course (like there's anyone else to blame...?) Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.