Maybe a bug in the Mesh.clone() method ?

[Temechon]

Hi all, 

 

I think I found a bug in the Mesh.clone() method (line 4 here) : 

// Buffersresult._vertexBuffers = this._vertexBuffers;for (var kind in result._vertexBuffers) {    result._vertexBuffers[kind].references++;}

VertexBuffer.references is not defined  => this line set the attribute references to all vertex buffer at NaN.

It should be : 

result._vertexBuffers[kind]._buffer.references++;

This bug caused some bad behaviour when all my cloned mesh were being disposed : 

BABYLON.VertexBuffer.prototype.dispose = function () {   this._engine._releaseBuffer(this._buffer);};

this._buffer.references were not incremented, and all my meshes were removed from screen

 

Is it possible to include this fix in the next version of babylon ?

 

Thanks

[gwenael]

Hi Temechon,

 

I may suggest you to do a pull request on GitHub. You seem to have fixed a bug and Deltakosh could check that in your fork and then merge it so your fix will be included to BabylonJS code.

 

BTW, no need to have a fork to do a pull request, you can directly modify the file on GitHub and GitHub will do the pull request for you

https://github.com/BabylonJS/Babylon.js/edit/master/Babylon/Mesh/babylon.mesh.js

[Temechon]

Hi Gwenael, 

 

I just did it. Thank you for this information, I didn't know you could do that ! You're a boss 

[gwenael]

I'm not the one who did the fix

[GameMonetize]

Validated and integrated

 

Thanks guys!