oschakravarthi Posted October 7, 2018 Share Posted October 7, 2018 Hi, The HighlightLayer is not working when we remove assets and add assets back. hl.addMesh(sphere, BABYLON.Color3.Green()); //Upto here it works perfectly. ///Let's remove all assets and put them back var keepAssets=new BABYLON.KeepAssets(); keepAssets.lights.push(light); keepAssets.cameras.push(camera); var container=new BABYLON.AssetContainer(scene); container.removeAllFromScene(keepAssets); container.addAllToScene(); ///They are back hl.addMesh(sphere, BABYLON.Color3.Green()); ///This won't work Here is the PG: https://www.babylonjs-playground.com/#1KUJ0A#142 Any Clue? Thanks in advance; Quote Link to comment Share on other sites More sharing options...
Wingnut Posted October 7, 2018 Share Posted October 7, 2018 Hi O! We probably need highlight-professor @Sebavan to help us with this. Other pros are nearby, too. I did some testing with your playground (thx for providing a good one to test-with). https://www.babylonjs-playground.com/#1KUJ0A#144 No solutions, yet. Just tests. Thx for the report! It is an interesting issue-find. hmm. Stay tuned. :) ssaket 1 Quote Link to comment Share on other sites More sharing options...
oschakravarthi Posted October 7, 2018 Author Share Posted October 7, 2018 2 hours ago, Wingnut said: Hi O! We probably need highlight-professor @Sebavan to help us with this. Other pros are nearby, too. I did some testing with your playground (thx for providing a good one to test-with). https://www.babylonjs-playground.com/#1KUJ0A#144 No solutions, yet. Just tests. Thx for the report! It is an interesting issue-find. hmm. Stay tuned. If you again instantiate the highlight layer after adding back the assets, it works ssaket 1 Quote Link to comment Share on other sites More sharing options...
ssaket Posted October 7, 2018 Share Posted October 7, 2018 yeahh... mostly it's a bug because the AssetContainer doesn't check for effectLayers(highlight), that's why it is not added back. I have made a PR; should be resolved soon! Thanks for pointing out Quote Link to comment Share on other sites More sharing options...
oschakravarthi Posted October 7, 2018 Author Share Posted October 7, 2018 Assets container is moving all the cameras which are created by VRExperienceHelper. It is also a bug Quote Link to comment Share on other sites More sharing options...
Guest Posted October 8, 2018 Share Posted October 8, 2018 pinging @trevordev Quote Link to comment Share on other sites More sharing options...
trevordev Posted October 8, 2018 Share Posted October 8, 2018 Tracking the highlight issue here: https://github.com/BabylonJS/Babylon.js/issues/5324 and PR is out. Im still not understanding the vr camera moving issue you describe. Is there a playground for that one? Sebavan and ssaket 2 Quote Link to comment Share on other sites More sharing options...
Sebavan Posted October 9, 2018 Share Posted October 9, 2018 Thanks @trevordev Quote Link to comment Share on other sites More sharing options...
oschakravarthi Posted October 28, 2018 Author Share Posted October 28, 2018 On 10/9/2018 at 12:09 AM, trevordev said: Tracking the highlight issue here: https://github.com/BabylonJS/Babylon.js/issues/5324 and PR is out. Im still not understanding the vr camera moving issue you describe. Is there a playground for that one? Thank you. I will create a PG for the VR camera moving issue. My brand new Dell laptop is went for servicing 2nd time. No laptop now.Only mobile. Once I get my laptop, i will create a PG GameMonetize and trevordev 2 Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.