phaselock Posted October 6, 2018 Share Posted October 6, 2018 Well, my codes were working fine yesterday, this morning something went awry with my pointer observables. Dug a little into it and found similar reproducible results in https://doc.babylonjs.com/how_to/interactions . The playground example (https://www.babylonjs-playground.com/#0XYMA9#1) is working fine for the stable version, when I switch to latest version, clicking on the sphere or plane no longer triggers the pointerup event until I doubleclick. Consistent in the console log as well. Quote Link to comment Share on other sites More sharing options...
Dad72 Posted October 6, 2018 Share Posted October 6, 2018 Yes I just saw the same behavior. The camera moves when you move the mouse after clicking on the scene. http://www.babylonjs-playground.com/#EEUVTY#11 Quote Link to comment Share on other sites More sharing options...
ssaket Posted October 6, 2018 Share Posted October 6, 2018 Hello All, yeah... this got introduced yesterday when we were trying to resolve - It's because introduction of this new variable - https://github.com/BabylonJS/Babylon.js/commit/9cc8c3e7a3a4c3e4d54f07a853acf6ca05ff1023#r30796147 Will make a new PR after testing thoroughly Meanwhile happy weekend ! My brain's bursting out ! The pointer events are too complicated Wingnut 1 Quote Link to comment Share on other sites More sharing options...
Guest Posted October 6, 2018 Share Posted October 6, 2018 My bad! Will be fix in a couple of minutes! Quote Link to comment Share on other sites More sharing options...
Guest Posted October 6, 2018 Share Posted October 6, 2018 Should be good now! Wingnut, ssaket, phaselock and 1 other 2 2 Quote Link to comment Share on other sites More sharing options...
Dad72 Posted October 6, 2018 Share Posted October 6, 2018 Yes, it's good. Quote Link to comment Share on other sites More sharing options...
phaselock Posted October 8, 2018 Author Share Posted October 8, 2018 Thanks, marking thread as solved. Quote Link to comment Share on other sites More sharing options...
TomaszFurca Posted October 9, 2018 Share Posted October 9, 2018 Hi, Could you verify that -> https://www.babylonjs-playground.com/#6K2WPZ When I use pointer down event and until i keep that, then i move my mouse to other location and then pointer up event is not fired. Quote Link to comment Share on other sites More sharing options...
aWeirdo Posted October 9, 2018 Share Posted October 9, 2018 @TomaszFurca Looks like the pointerUp event is 'counted' as a pointerMove. > Observers still work, only scene.onPointerUp seems to be affected. > clickInfo.ignore is always true. (should be false for onPointerUp..) http://playground.babylonjs.com/#UM43F8#1 @Deltakosh I have to run so i'll tag this for you. scene -> attachControl -> _initClickEvent -> always sets "clickInfo.ignore = true" before callback is called. See line 177 -> http://playground.babylonjs.com/#UM43F8#5 ( commented it out, and onPointerUp works again ) Is there a reason for that to be there`? Quote Link to comment Share on other sites More sharing options...
Guest Posted October 9, 2018 Share Posted October 9, 2018 Yes this is still the same issue I try to fix since ages Hopefully it should be good now on the latest nightly aWeirdo and TomaszFurca 2 Quote Link to comment Share on other sites More sharing options...
phaselock Posted October 11, 2018 Author Share Posted October 11, 2018 Dunno what was done, but I'm now getting pointerup events firing twice in my app. Is there anything I should add into my codes with the new changes ? Quote Link to comment Share on other sites More sharing options...
phaselock Posted October 11, 2018 Author Share Posted October 11, 2018 ok, this is a weird bug....finally got the repro. https://www.babylonjs-playground.com/index.html#0XYMA9#2 Open the console and play with this: a) click in the PG canvas, console should throw 2 counts of pointer up events. b) Comment out camera.attachControl FOR the arc rotate camera, click run, click in canvas, console now throws 1 count of pointer up event. c) Comment out var camera = new BABYLON.ArcRotateCamera..., uncomment the 2 lines on freecamera, click run, click in canvas, console throws 1 count of pointer up event. So, it would seem like attach control for arc rotate camera is the bug....weird right ? Quote Link to comment Share on other sites More sharing options...
Guest Posted October 11, 2018 Share Posted October 11, 2018 Weird! I'm checking right now Quote Link to comment Share on other sites More sharing options...
Guest Posted October 11, 2018 Share Posted October 11, 2018 Ok will be fixed by next commit! phaselock and ssaket 2 Quote Link to comment Share on other sites More sharing options...
QuintusHegie Posted October 11, 2018 Share Posted October 11, 2018 FYI Playground http://www.babylonjs-playground.com/#7RH606 from https://doc.babylonjs.com/how_to/gui probably has same error. When you click the button it doesn't count (call the onPointerClickObservable). Quote Link to comment Share on other sites More sharing options...
phaselock Posted October 18, 2018 Author Share Posted October 18, 2018 looks good for me now, marking as solved. Thanks, @Deltakosh ! GameMonetize 1 Quote Link to comment Share on other sites More sharing options...
MarianG Posted November 6, 2018 Share Posted November 6, 2018 @Deltakosh I think the bug is still around. Again here, line 71, never call. Only with latest version Quote Link to comment Share on other sites More sharing options...
Guest Posted November 6, 2018 Share Posted November 6, 2018 yep good catch..I missed that one Will be in next commit Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.