Maintain cameras and lights while doing addAllToScene and removeAllFromScene

[oschakravarthi]

Hi,

When I do container.removeAllFromScene and container.addAllToScene, the cameras and lights should  be maintained properly.  But it is not happening. How can I achieve that?

[Guest]

Pinging @trevordev

[Wingnut]

Hi guys, sorry to interrupt, but I MIGHT know a "dirty" way.

http://playground.babylonjs.com/#YATDM6

Just include those top two functions... into your project... at the top (like that playground does).  Scary kind of hacking. 

I didn't test it... but in theory, it MIGHT work... at least for a temporary solve.

Keep in mind that this PERMANENTLY modifies the container's add-all and remove-all.  You will need to MANUALLY default the code back to normal, if you need default ops, later.

Sorry for the interrupt... back to wisdom and sanity, now. 

[trevordev]

@oschakravarthi see https://doc.babylonjs.com/how_to/how_to_use_assetcontainer , KeepAssets can be used to maintain objects when removing objects from the scene. When adding objects to the scene, you can inspect the scene.activeCamera and scene.lights and remove the ones that are not in your keep assets object.

[oschakravarthi]

8 hours ago, trevordev said:

@oschakravarthi see https://doc.babylonjs.com/how_to/how_to_use_assetcontainer , KeepAssets can be used to maintain objects when removing objects from the scene. When adding objects to the scene, you can inspect the scene.activeCamera and scene.lights and remove the ones that are not in your keep assets object.

1

 

Hi @trevordev

 

Thanks a lot for your continuous support.

So, we need to load all the assets before calling scene.createDefaultVRExperience(). 

If we load assets after instantiating scene.createDefaultVRExperience(), it causes a big problem. The VRExperienceHelper creates some cameras and adds them the scene. If we use moveAllFromScene, it will move all the cameras including those who are created by the VRExperienceHelper. It is the problem I am facing.

 

So, you may ask for such a scenario where we load assets after entering VR mode.

Scenario 1: Assume that we are in a VR game. We have our assets like Level1.babylon, Level2.babylon etc... in the server.  While the user is playing and progressing, new levels will be loaded. 

Scenario 2: There is a Real estate application in which the user can explore various flats and projects in VR mode. 

 

There can be many scenarios like this.

 

So, what I did? I have taken the source code of AssetContainer and commented the lines which add or remove cameras. It worked.

 

As these scenarios are very valid, I request some more options in AssetContainer.

[oschakravarthi]

On 10/6/2018 at 7:08 AM, oschakravarthi said:

 

Hi @trevordev

 

Thanks a lot for your continuous support.

So, we need to load all the assets before calling scene.createDefaultVRExperience(). 

If we load assets after instantiating scene.createDefaultVRExperience(), it causes a big problem. The VRExperienceHelper creates some cameras and adds them the scene. If we use moveAllFromScene, it will move all the cameras including those who are created by the VRExperienceHelper. It is the problem I am facing.

 

So, you may ask for such a scenario where we load assets after entering VR mode.

Scenario 1: Assume that we are in a VR game. We have our assets like Level1.babylon, Level2.babylon etc... in the server.  While the user is playing and progressing, new levels will be loaded. 

Scenario 2: There is a Real estate application in which the user can explore various flats and projects in VR mode. 

 

There can be many scenarios like this.

 

So, what I did? I have taken the source code of AssetContainer and commented the lines which add or remove cameras. It worked.

 

As these scenarios are very valid, I request some more options in AssetContainer.

@ssaket, please look at this as well

[ssaket]

@oschakravarthi I think this might be helpful for you - https://www.babylonjs-playground.com/#JA1ND3#48. 

you can have your levels in scene[] which you can query from your server and also can manipulate camera and light as per your need. I don't know much about VR  

 

[trevordev]

@oschakravarthi You shouldn't need to load all assets prior to entering vr. You just need to make sure that your assets to overwrite the active camera. You can load an asset container at any time and it shouldn't modify the scene until you call addAllToScene. What feature would you like to add?