blondegeek Posted September 21, 2018 Share Posted September 21, 2018 Hello, I am using a cylinder (created with CreateTube) to visualize a SpringJoint. The cylinder is updated in scene.registerBeforeRender. The following code works with BabylonJS v3.2 but breaks for v3.3. https://gist.github.com/blondegeek/d47355372f8cad3b373a10cb0879ba5c If you want the specific babylon libraries I'm using please see the babylon.custom.3.*.js files in: https://gist.github.com/blondegeek/f6e5ca0fb42765a073de831b8808729f Any idea what is causing this change in behavior between versions? Thanks! Quote Link to comment Share on other sites More sharing options...
jerome Posted September 21, 2018 Share Posted September 21, 2018 Could you please create a PG ( https://playground.babylonjs.com/ ) to isolate the issue ? As far as I know, nothing has changed in the tube implementation : https://github.com/BabylonJS/Babylon.js/blob/master/dist/preview release/what's new.md Quote Link to comment Share on other sites More sharing options...
aWeirdo Posted September 21, 2018 Share Posted September 21, 2018 Something went wrong, somewhere, somehow.. From docs example: Stable works; https://www.babylonjs-playground.com/indexStable.html#ACKC2#1 Latest doesn't; https://www.babylonjs-playground.com/index.html#ACKC2#1 blondegeek 1 Quote Link to comment Share on other sites More sharing options...
jerome Posted September 21, 2018 Share Posted September 21, 2018 Mmmh really weird indeed. I just checked in the Github PR history : the latest changes in the Tube or Ribbon code (the tube is a ribbon-based shape) are at least one year old. Moreover the bug happens only on the tube update. So I guess this issue doesn't come from the tube geometry itself but rather from the vertex buffer update : how or when it's updated ? Can someone here remember about a recent change in the ribbon update ? I can see this about some _creationDataStorage that I don't really know : https://github.com/BabylonJS/Babylon.js/blob/master/src/Mesh/babylon.meshBuilder.ts#L241 https://github.com/BabylonJS/Babylon.js/blob/master/src/Mesh/babylon.meshBuilder.ts#L203 Not sure it's the reason though, but the rest of the existing looks still familiar to me blondegeek 1 Quote Link to comment Share on other sites More sharing options...
Sebavan Posted September 21, 2018 Share Posted September 21, 2018 Yup probably related to this, I am on it : https://github.com/BabylonJS/Babylon.js/issues/5220 I ll keep you posted. blondegeek and jerome 2 Quote Link to comment Share on other sites More sharing options...
aWeirdo Posted September 21, 2018 Share Posted September 21, 2018 @Sebavan Possibly related to tube._creationDataStorage = new BABYLON._CreationDataStorage(); in MeshBuilder.CreateTube .. some values aren't passed to instance, and thus are undefined after one update. (but still attempted to be used) blondegeek 1 Quote Link to comment Share on other sites More sharing options...
Sebavan Posted September 21, 2018 Share Posted September 21, 2018 Yup for sure it is, I am looking into why we duplicated it and will push a fix ASAP. Quote Link to comment Share on other sites More sharing options...
Sebavan Posted September 21, 2018 Share Posted September 21, 2018 I am deploying the fix in 5 minutes blondegeek 1 Quote Link to comment Share on other sites More sharing options...
Sebavan Posted September 21, 2018 Share Posted September 21, 2018 Fixed jerome 1 Quote Link to comment Share on other sites More sharing options...
blondegeek Posted September 21, 2018 Author Share Posted September 21, 2018 Hi all, Thanks so much for your responses. @Sebavan That seemed to fix the whatever was preventing the shape of the tube being updated. I'm still however seeing a seam in the tube that wasn't there before (picture attached). Have the behavior of the input parameters changed? Thanks! Quote Link to comment Share on other sites More sharing options...
Guest Posted September 21, 2018 Share Posted September 21, 2018 Nope this is just us being stupid..Will fix that NOW Quote Link to comment Share on other sites More sharing options...
Guest Posted September 21, 2018 Share Posted September 21, 2018 Will be fixed in 2 minutes and live in 5! blondegeek and jerome 2 Quote Link to comment Share on other sites More sharing options...
blondegeek Posted September 21, 2018 Author Share Posted September 21, 2018 Hi @Deltakosh, Thanks for help! Will this change be reflected in the preview libraries? (<script src="https://preview.babylonjs.com/...") I'm still seeing the same problem. Quote Link to comment Share on other sites More sharing options...
blondegeek Posted September 22, 2018 Author Share Posted September 22, 2018 Just checked this again right now. Looks like it's fixed for the preview libraries. Thanks again @Deltakosh! Quote Link to comment Share on other sites More sharing options...
Guest Posted September 24, 2018 Share Posted September 24, 2018 My pleasure! Quote Link to comment Share on other sites More sharing options...
jerome Posted September 24, 2018 Share Posted September 24, 2018 ultra fast and accurate fix, thank you guys Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.