solved Default Rendering Pipeline and colorGrading

[V!nc3r]

Is my setup of LUT texture inside defaultRenderingPipeline wrong? https://www.babylonjs-playground.com/#23YL1J#2 (play with boolean line 12)

I don't understand why I haven't the same render than the LUT post process. Bug or PEBKAC?

[Sebavan]

I am on it but I suspect it is because you are not relying on an sdl file, I let you know ASAP

[Sebavan]

So to use the same texture a bit of trickery is required as the default is sdl format.

So you need to not inverse the texture and not use the green channel for depth: https://www.babylonjs-playground.com/#23YL1J#5

I am now looking into the post process configuration as smthg seems off.

[V!nc3r]

25 minutes ago, Sebavan said:

as the default is sdl format

erf OK! I miss that info 'cause I've seen on the API that we need a colorGradingTexture: Nullable<BaseTexture>. Shouldn't be said colorGradingTexture: Nullable<ColorGradingTexture> instead?

Thanks for the tips :)

[Sebavan]

It defaults to it but png are allowed, just need a tiny bit of conf ?

[Sebavan]

So here you go: https://www.babylonjs-playground.com/#23YL1J#6

 

[V!nc3r]

OK, very nice, thanks!

I don't find your tips in the doc', am I missing something? Should probably be here I think: http://doc.babylonjs.com/how_to/how_to_use_postprocesses#imageprocessing

The associated colorGrading playground actually use this 3dl texture, could be a nice idea to give also an example with png, what do you think?

 

[Sebavan]

@V!nc3r, Would be amazing !!!  fancy creating a PR ?

[V!nc3r]

'can do that

[V!nc3r]

PR done.

I notice we get some edge-detection-artefacts when increasing the default contrast, example: https://www.babylonjs-playground.com/#K4S3GU#28

But these artefacts aren't here when I tweak the LUT from Photoshop. Is it another properties combination where I'm wrong? ?

[edit] is it have something to deal with mipmaps? (even if noMipmaps is set to true?)

[Sebavan]

Yup another setting, you were not far with mipmaps it has to do with wrapping. 

The texture needs to not be in wrap mode repeat: https://www.babylonjs-playground.com/#K4S3GU#29

[V!nc3r]

So, another PR in its way

Seems to works perfectly now, Thanks !

[V!nc3r]

hmm, yep, me again, sorry if I bored you ahah.

I've still the bug, in this test scene for example: https://www.babylonjs-playground.com/#XYK7JG#1 with - I think- all the tweaks you told me, and using pipeline.

Make some test on our usual thread playground with kind-of same settings : https://www.babylonjs-playground.com/#K4S3GU#32 and here, all works fine.

[edit: woops, actually artefact spotted! /edit]

I tryied to understand from where the issue comes in the cornell box playground, and the only thing I found but don't understand why is that these artefacts disappear when I comment the light creation (line 10) https://www.babylonjs-playground.com/#XYK7JG#2

Have we something clamped somewhere, and another setting to add to the doc' ?

[Sebavan]

I am wondering if it is not related to of the colors are mapped in the LUT.

Could you try a sdl file instead ? On webgl2 browsers this would be blazing fast as it would rely on 3d texture and interpolations would not be an issue anymore.

[V!nc3r]

So, I tried with a .3dl. (didn't know until now that Photoshop allowing exporting this, thanks for the discorvery )

But, some colors looks inverted:

Here my process in video: https://www.dropbox.com/s/fce6bj1ho7xvohf/photoshop-LUT-exporting.mp4?dl=0

And, of course, the playground: https://www.babylonjs-playground.com/#K4S3GU#35

and my .3dl direct link., compared to the BJS one online, I don't know if something is wrong here:

I tried playing with the colorGradingWithGreenDepth things, same issue. But at least, no artefacts... just wrong colors

(I think the doc' will be updated soon after all that things fixed ahah)

 

[Sebavan]

I ll check as soon as I finish a bug fix on tube update.

[Sebavan]

Yup it seems the colors are ordered in the other way ? I ll try to find where this comes from in the parameter and if I do not I ll add a way to reverse the texture on z.

 

[Sebavan]

@V!nc3r or @PatrickRyan Could you please export an identity 3dl for me ? 

This would be the easiest to test the setup.

[Sebavan]

@V!nc3r thanks a lot for your diggin I was able to fix to issues with the parser: https://github.com/BabylonJS/Babylon.js/pull/5229

It should be all good now and way easier for you to create amazing effects from toshop exports.

[PatrickRyan]

9 hours ago, Sebavan said:

@V!nc3r or @PatrickRyan Could you please export an identity 3dl for me ? 

This would be the easiest to test the setup.

@Sebavan here is your identity LUT if you still need one. I am starting a repo for LUTs for us to use/share. Yours is the first.

https://github.com/PatrickRyanMS/BabylonJStextures/tree/master/LUT 

or if you just want the raw link to include in your PG:

https://raw.githubusercontent.com/PatrickRyanMS/BabylonJStextures/master/LUT/NoAdjustment.3DL

[V!nc3r]

Sorry for the delay (vacations), and nice job for the fix!

Here my NoAdjustment.3dl file (from Photoshop CC 2017.1.1)