heyzxz Posted March 7, 2018 Share Posted March 7, 2018 Hi there, I think this 'break' should be removed, because one userAgent may match multiple items in ExceptionList. For example: a userAgent of Firefox/58 on a Macintosh, currently only 'Firefox/58' handled, the 'Macintosh' is ignored because of the break... Quote Link to comment Share on other sites More sharing options...
RaananW Posted March 7, 2018 Share Posted March 7, 2018 Want to offer a PR? we can discuss it in GitHub (A better place to talk about code ) Quote Link to comment Share on other sites More sharing options...
Guest Posted March 7, 2018 Share Posted March 7, 2018 You are totally right ! I'll fix it (but @RaananW is also right do not hesitate to contribute) Quote Link to comment Share on other sites More sharing options...
heyzxz Posted March 7, 2018 Author Share Posted March 7, 2018 Thank you! And sorry I'm not very familiar with Github, does 'PR' means Pull Request? I'll try next time RaananW 1 Quote Link to comment Share on other sites More sharing options...
Guest Posted March 8, 2018 Share Posted March 8, 2018 yes sorry, PR = Pull request Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.