BlackMojito Posted March 5, 2018 Share Posted March 5, 2018 I've got an error at this line as document is undefined in a worker. Would you please take a look? And how can I temporarily work around this? https://github.com/BabylonJS/Babylon.js/blob/b7ea78f814c9639d9ace2b4dd2b5b42474898b5d/src/Mesh/Compression/babylon.dracoCompression.ts#L191 Quote Link to comment Share on other sites More sharing options...
Guest Posted March 5, 2018 Share Posted March 5, 2018 I'll fix it for next commit Quote Link to comment Share on other sites More sharing options...
BlackMojito Posted March 6, 2018 Author Share Posted March 6, 2018 14 hours ago, Deltakosh said: I'll fix it for next commit Will the fix be available in alphaC? I rolled back to alpha7 for now... Quote Link to comment Share on other sites More sharing options...
Guest Posted March 6, 2018 Share Posted March 6, 2018 yes it will Quote Link to comment Share on other sites More sharing options...
BlackMojito Posted March 8, 2018 Author Share Posted March 8, 2018 On 2018/3/7 at 4:26 AM, Deltakosh said: yes it will BTW big boss, when will alphaC available? Quote Link to comment Share on other sites More sharing options...
Guest Posted March 8, 2018 Share Posted March 8, 2018 This friday (pinging @RaananW) Quote Link to comment Share on other sites More sharing options...
RaananW Posted March 8, 2018 Share Posted March 8, 2018 this friday it is! I will update npm tomorrow. Quote Link to comment Share on other sites More sharing options...
BlackMojito Posted March 13, 2018 Author Share Posted March 13, 2018 On 2018/3/6 at 12:46 AM, Deltakosh said: I'll fix it for next commit Hi Boss, there is a bug in your fix. https://github.com/BabylonJS/Babylon.js/blob/74fc8a3c1cb2407ea4faaba292f3a881057fc65d/src/Mesh/Compression/babylon.dracoCompression.ts#L191 I think it should be if (!Tools.IsWindowObjectExist()) { PR submitted https://github.com/BabylonJS/Babylon.js/pull/3937/files. BTW, when can we get the next alpha version which integrates the fix? Quote Link to comment Share on other sites More sharing options...
RaananW Posted March 13, 2018 Share Posted March 13, 2018 next release is wednesday (tomorrow). so, soon! Quote Link to comment Share on other sites More sharing options...
Guest Posted March 13, 2018 Share Posted March 13, 2018 Thanks! Quote Link to comment Share on other sites More sharing options...
BlackMojito Posted March 15, 2018 Author Share Posted March 15, 2018 On 2018/3/13 at 7:34 PM, RaananW said: next release is wednesday (tomorrow). so, soon! BTW, when will you update npm? Thanks! Quote Link to comment Share on other sites More sharing options...
BlackMojito Posted March 15, 2018 Author Share Posted March 15, 2018 Unluckily the fix is not in 3.2.0-beta.1... Quote Link to comment Share on other sites More sharing options...
Guest Posted March 15, 2018 Share Posted March 15, 2018 it should ! Quote Link to comment Share on other sites More sharing options...
BlackMojito Posted March 16, 2018 Author Share Posted March 16, 2018 9 hours ago, Deltakosh said: it should ! It is in the preview branch but not the master branch. Well I downloaded beta.1 and the fix was not in it. Quote Link to comment Share on other sites More sharing options...
Guest Posted March 16, 2018 Share Posted March 16, 2018 Really sorry. It is now on the master branch Sorry about that! Quote Link to comment Share on other sites More sharing options...
BlackMojito Posted March 18, 2018 Author Share Posted March 18, 2018 On 2018/3/17 at 2:30 AM, Deltakosh said: Really sorry. It is now on the master branch Sorry about that! No worry, I can temporarily modify the source babylon.js Quote Link to comment Share on other sites More sharing options...
Guest Posted March 19, 2018 Share Posted March 19, 2018 should be good! Quote Link to comment Share on other sites More sharing options...
RaananW Posted March 21, 2018 Share Posted March 21, 2018 I will push beta.2 today or tomorrow. Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.