GameMonetize Posted January 18, 2018 Share Posted January 18, 2018 I'm interested by solution 2 but I do not want to introduce big changes on a material which is used everywhere ;D Perhaps we could add anchor points in the shader code? something like /* end of diffuse */ that we can then replace at custom material level? jsut playing a search/replace game? NasimiAsl 1 Quote Link to comment Share on other sites More sharing options...
NasimiAsl Posted January 18, 2018 Share Posted January 18, 2018 it is so close to your solution Quote Link to comment Share on other sites More sharing options...
GameMonetize Posted January 18, 2018 Share Posted January 18, 2018 where do you want to add these anchors? (I mean inside the main shader) Quote Link to comment Share on other sites More sharing options...
NasimiAsl Posted January 18, 2018 Share Posted January 18, 2018 Vertex ( begin before Includes and definition + before main + begin main + Position update + normal update + before gl position set ) Fragment ( begin before Includes and definition + before main + begin main + custom diffuse + custom alpha + before FragColor ) need make changeable normal variable for both need define UV uniform like enable property make create new shader for instance if the customizable property is true we need check this bug for standard material with new shader Quote Link to comment Share on other sites More sharing options...
NasimiAsl Posted January 20, 2018 Share Posted January 20, 2018 @Deltakosh if you think i can help i am ready for fork this is not small change but the core of standard material untouched in this task Quote Link to comment Share on other sites More sharing options...
GameMonetize Posted January 22, 2018 Share Posted January 22, 2018 We can discuss over a PR. The main idea is to not be forced to have a copy of the standard mat but instead rely on the main one Quote Link to comment Share on other sites More sharing options...
NasimiAsl Posted January 23, 2018 Share Posted January 23, 2018 i am on it Dad72 and GameMonetize 2 Quote Link to comment Share on other sites More sharing options...
Pryme8 Posted January 24, 2018 Share Posted January 24, 2018 Wow big things in this thread. Cant wait to see the outcome! thanks @NasimiAsl & @Deltakosh <3 Dad72 1 Quote Link to comment Share on other sites More sharing options...
NasimiAsl Posted February 3, 2018 Share Posted February 3, 2018 ok @Dad72 that close to Make PR so for be sure make all bug custom material you have in your mind replay here 1. append Light after some times is test Dad72 1 Quote Link to comment Share on other sites More sharing options...
Dad72 Posted February 3, 2018 Author Share Posted February 3, 2018 Cool, thanks Nasimi. I can not wait to test. Does a lot of things change? we will have to revise our code? Quote Link to comment Share on other sites More sharing options...
NasimiAsl Posted February 3, 2018 Share Posted February 3, 2018 you will see but it is correctly in customMaterial design pattern Quote Link to comment Share on other sites More sharing options...
NasimiAsl Posted February 3, 2018 Share Posted February 3, 2018 new changes is changed Quote Link to comment Share on other sites More sharing options...
Dad72 Posted February 4, 2018 Author Share Posted February 4, 2018 Yes I saw this on GitHub. and what is your idea then ? Quote Link to comment Share on other sites More sharing options...
NasimiAsl Posted February 4, 2018 Share Posted February 4, 2018 i think i can make fast way for solve this problem just need commit shader define's Quote Link to comment Share on other sites More sharing options...
Dad72 Posted February 4, 2018 Author Share Posted February 4, 2018 But are you going to delete old_StandardMaterial from the CustomMaterial file? Quote Link to comment Share on other sites More sharing options...
Dad72 Posted February 10, 2018 Author Share Posted February 10, 2018 On 04/02/2018 at 1:20 PM, NasimiAsl said: i think i can make fast way for solve this problem just need commit shader define's I come to the news concerning this fast resolution. Quote Link to comment Share on other sites More sharing options...
Dad72 Posted February 14, 2018 Author Share Posted February 14, 2018 @NasimiAsl Could you answer? CustomMateriel does not work anymore. I think the StandardMateriel_oldVesion part in the CustomMateriel class is a very bad idea. Are you planning to do something for CustomMateriel or have you given up ? NasimiAsl 1 Quote Link to comment Share on other sites More sharing options...
NasimiAsl Posted February 14, 2018 Share Posted February 14, 2018 some time i need stay and just look and don't change it is not good way for programming when you have solution start that fast you most try find better solution *** this is important we can have old version support for our source *** BABYLONJS design pattern don't have any plan for that (maybe i don't know it) so i wanna make new plan for standard material for have customizable that but it is not perfect for now GameMonetize 1 Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.