engine.getAspectRatio(); does not work until resize?

[Pryme8]

https://pryme8.github.io/TileMaster/editor/

So If you go ahead and create a new project, then add a stage, then add a plane.  You will see the bug.  Notice you see no change and if you have the console open you will see NAN outputs for the aspectRatio.

Now the second you resize the scene it fixes this and starts correctly outputting the aspectRatio
https://github.com/Pryme8/TileMaster/blob/gh-pages/editor/js/tm.editor.js#L394

Is where the function is used and
https://github.com/Pryme8/TileMaster/blob/gh-pages/editor/js/tm.editor.js#L34
Is where it fires from... the odd part is technically I fire the resize manually before anything happens so shouldn't this work?

 

[GameMonetize]

AFAIC, the only way to get NAN would be to call getAspectRatio too early (when the canvas is not yet attached to the DOM).

https://github.com/BabylonJS/Babylon.js/blob/master/src/Engine/babylon.engine.ts#L1294

 

[Pryme8]

its after DOM creation, I added 
this._core.engine.resize();

to the _buildMesh function and that "fixed" it but proves that there is a bug somewhere.
 

[GameMonetize]

Somewhere

When I step into getAspectRatio I see that the engine.getRenderingCanvas().width === 0

 

Not good

[Pryme8]

so did i find a bug?!?! woot!

[Pryme8]

Why does :https://github.com/BabylonJS/Babylon.js/blob/master/src/Engine/babylon.engine.ts#L1294
not just use https://github.com/BabylonJS/Babylon.js/blob/master/src/Engine/babylon.engine.ts#L1319
and do something like:

var rect = this.getRenderingCanvasClientRect();
return rect.width / rect.height;

?

[Pryme8]

for the time being i replaced the line:
var aspectRatio = engine.getAspectRatio(c);
with:
var rect = engine.getRenderingCanvasClientRect();
var aspectRatio = rect.width/rect.height;

and it seems to be adequate as a work around so no rush on this problem... but I am kinda wondering what the root cause of it is still.

*EDIT*
that did not fix it actually, but I made a work around.

[GameMonetize]

It is not a bug on my side  I'm not responsible to set the canvas.width

[Pryme8]

Im bringing this topic back... there is something odd in this behavior.

So basically my scenes are broken until I fire a engine.resize();

I am thinking this is because the canvas elements are set to display:none initially and are enabled later.  

But here is where things get odd, if I do a engine resize prior to the display of the canvas its like nothing effectively happens.

I am forced then to do this:
https://github.com/Pryme8/TileMaster/blob/gh-pages/editor/js/tm.editor.js#L104
which seem really kinda dumb... I mean it works but if I nerf these lines when you select a tile it displays it in the preview block like its a single pxl from the center of the tile is the only one that displays over the whole canvas.

But if I include these lines everything "works"
http://pryme8.github.io/TileMaster/editor

I am focused on the sheetEditor part if your looking for the working example.

[GameMonetize]

This is expected. The engine cannot resize until the canvas has an actual size. I don't know how to do it differently unfortunately

[Pryme8]

Ok so doing a manual resize after the canvas is being displayed on the dom would be the best work around?

[GameMonetize]

correct