BlackMojito Posted November 14, 2017 Share Posted November 14, 2017 Hi Folks, I tried to integrate the SSAO pipeline with as shown in this sample https://www.babylonjs-playground.com/?24. However the result was not correct if I set the scene to using right hand system. The occlusion result does not follow the camera move. I think should be a calculation error linked either to the projection matrix or to the view matrix. I really think that it is a serious bug. I don't want to change my whole application to left hand system Thanks Quote Link to comment Share on other sites More sharing options...
GameMonetize Posted November 14, 2017 Share Posted November 14, 2017 Can you provide a repro in the playground? Ping @Luaacro Quote Link to comment Share on other sites More sharing options...
julien-moreau Posted November 14, 2017 Share Posted November 14, 2017 Good Catch! @Deltakosh, it is related to the depth renderer: faces are inverted. Looking for a reason Not the SSAO itself as it is just screenspace Quote Link to comment Share on other sites More sharing options...
GameMonetize Posted November 14, 2017 Share Posted November 14, 2017 @Luaacro fixed it Will publish soon:) Quote Link to comment Share on other sites More sharing options...
julien-moreau Posted November 14, 2017 Share Posted November 14, 2017 Fixed here! https://github.com/BabylonJS/Babylon.js/pull/3149 @Deltakosh will tell you if fixed right EDIT: he already told you ahah Quote Link to comment Share on other sites More sharing options...
BlackMojito Posted November 18, 2017 Author Share Posted November 18, 2017 On 11/15/2017 at 12:25 AM, Deltakosh said: Can you provide a repro in the playground? Ping @Luaacro I am sorry I just saw your reply. Luckily you guys have already fixed the bug. Thanks you so much. That's really cool! GameMonetize 1 Quote Link to comment Share on other sites More sharing options...
BlackMojito Posted December 14, 2017 Author Share Posted December 14, 2017 Is this fix in 3.1.1? I still see the bug when using right handed system. Quote Link to comment Share on other sites More sharing options...
Pryme8 Posted December 14, 2017 Share Posted December 14, 2017 On 11/14/2017 at 9:14 AM, Luaacro said: Good Catch! @Deltakosh, it is related to the depth renderer: faces are inverted. Looking for a reason Not the SSAO itself as it is just screenspace What debug tool is this? Quote Link to comment Share on other sites More sharing options...
GameMonetize Posted December 15, 2017 Share Posted December 15, 2017 Spector.js: https://github.com/BabylonJS/Spector.js Pryme8 1 Quote Link to comment Share on other sites More sharing options...
GameMonetize Posted December 15, 2017 Share Posted December 15, 2017 Btw the fix should be in. Let me ping @Luaacro julien-moreau 1 Quote Link to comment Share on other sites More sharing options...
julien-moreau Posted December 15, 2017 Share Posted December 15, 2017 Hello @BlackMojito! I cannot reproduce the bug here, it is working well =O Quote Link to comment Share on other sites More sharing options...
julien-moreau Posted December 15, 2017 Share Posted December 15, 2017 @Deltakosh Can anybody confirm ? https://www.babylonjs-playground.com/#FD9LBC Quote Link to comment Share on other sites More sharing options...
BlackMojito Posted December 15, 2017 Author Share Posted December 15, 2017 4 hours ago, Luaacro said: Hello @BlackMojito! I cannot reproduce the bug here, it is working well =O Please take a look at https://www.babylonjs-playground.com/#ADEN9S, the bug is present when we use SSAO2. I guess there is something wrong with MultiRenderTarget. Quote Link to comment Share on other sites More sharing options...
julien-moreau Posted December 15, 2017 Share Posted December 15, 2017 Pull Request created: https://github.com/BabylonJS/Babylon.js/pull/3404 Quote Link to comment Share on other sites More sharing options...
BlackMojito Posted December 17, 2017 Author Share Posted December 17, 2017 On 12/16/2017 at 2:00 AM, Luaacro said: Pull Request created: https://github.com/BabylonJS/Babylon.js/pull/3404 Cool! Thanks! Quote Link to comment Share on other sites More sharing options...
BlackMojito Posted December 21, 2017 Author Share Posted December 21, 2017 BTW, when will it be available? All my stuff is based on right handed system. I am not reversing all z values when importing my meshes Quote Link to comment Share on other sites More sharing options...
GameMonetize Posted December 21, 2017 Share Posted December 21, 2017 It is already on 3.2 julien-moreau 1 Quote Link to comment Share on other sites More sharing options...
julien-moreau Posted December 21, 2017 Share Posted December 21, 2017 @BlackMojito you confirm that it works well ? Quote Link to comment Share on other sites More sharing options...
BlackMojito Posted December 22, 2017 Author Share Posted December 22, 2017 6 hours ago, Luaacro said: @BlackMojito you confirm that it works well ? OK Sure. Then may be it will be first in an alpha version so that I will confirm? Quote Link to comment Share on other sites More sharing options...
BlackMojito Posted January 3, 2018 Author Share Posted January 3, 2018 On 12/22/2017 at 3:16 AM, Luaacro said: @BlackMojito you confirm that it works well ? Hi @Luaacro, I tried it with 3.2.0-alpha0 and it still doesn't work. I've debugged into babylon.max.js and your fix was in it. I've also checked it with the SSAO2 playground https://www.babylonjs-playground.com/#ADEN9S and it did not work either. So maybe there are other deeper reasons? Quote Link to comment Share on other sites More sharing options...
julien-moreau Posted January 3, 2018 Share Posted January 3, 2018 It looks like SSAO is broken when I run the original playground Pinging @Deltakosh and Craig Quote Link to comment Share on other sites More sharing options...
GameMonetize Posted January 3, 2018 Share Posted January 3, 2018 Fixed now! Quote Link to comment Share on other sites More sharing options...
BlackMojito Posted January 4, 2018 Author Share Posted January 4, 2018 7 hours ago, Deltakosh said: Fixed now! Thanks! Quote Link to comment Share on other sites More sharing options...
BlackMojito Posted January 8, 2018 Author Share Posted January 8, 2018 On 1/3/2018 at 11:20 PM, Luaacro said: It looks like SSAO is broken when I run the original playground Pinging @Deltakosh and Craig Hi @Luaacro, the SSAO2 playground works now. But still only for Left Handed System. It seems that your fix is already in the release. Still other causes? Quote Link to comment Share on other sites More sharing options...
julien-moreau Posted January 8, 2018 Share Posted January 8, 2018 Taking a look ! Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.