Three.js or Babylon.js for room design

[max123]

6 minutes ago, adam said:

In the case, the user should be reusing Rays.

When you call 
 

public pickWithRay(ray: Ray, predicate: (mesh: Mesh) => boolean, fastCheck?: boolean): PickingInfo {

return this._internalPick(world => {

if (!this._pickWithRayInverseMatrix) {

this._pickWithRayInverseMatrix = Matrix.Identity();

}

world.invertToRef(this._pickWithRayInverseMatrix);

return Ray.Transform(ray, this._pickWithRayInverseMatrix);

}, predicate, fastCheck);

}

Ray.Transform returns new Ray. 

[adam]

 

[adam]

There are actually 2 objects getting created there.  A pickingInfo object and a Ray.

The Ray creation could be eliminated by using a tmpRay in the scene.pickWithRay functions.

To eliminate the pickingInfo object creation, there would need to be a new scene.pickWithRayToRef which the user would pass a pickingInfo object. (this one looks a little difficult and might not be worth it)

[max123]

9 minutes ago, adam said:

There are actually 2 objects getting created there.  A pickingInfo object and a Ray.

The Ray creation could be eliminated by using a tmpRay in the scene.pickWithRay functions.

To eliminate the pickingInfo object creation, there would need to be a new scene.pickWithRayToRef which the user would pass a pickingInfo object. (this one looks a little difficult and might not be worth it)

Well, a pickInfo object is a necessary evil: you do need to return the result of picking  

[adam]

If you could pass the function your own pickingInfo object then it could pass that to a new mesh.intersectsToRef and eliminate the creation of PickingInfo here:

https://github.com/BabylonJS/Babylon.js/blob/master/src/Mesh/babylon.abstractMesh.ts#L1817

Like I said though, it might not be worth the trouble.

[GameMonetize]

Always eager to improve the engine. I will work on removing this ugly Ray.Transform

Regarding camera, the inputs are pretty well separated to me: http://doc.babylonjs.com/how_to/customizing_camera_inputs

Then each camera has a specific design (ArcRotate, Free).

 

[GameMonetize]

Ok the Ray.Transform will be fixed with next nightly

@max123: Feel free to give us other feedback / improvements that you may have. It is the best way to improve the engine

[GameMonetize]

For your CSS remark: I agree we should not have to do it but it saves us so many questions on why the inputs are not working on my canvas  Perhaps we should add a: engine.dontTouchMyzIndex or something along these lines

[JCPalmer]

Personally, I have found BJS to not be OOP enough.  Not in the framework itself, but in ones ability to easily subclass something in typescript.  I just have been doing PR's to switch private properties / methods to protected in instances where I have hit walls.  I also reorganized Mesh a little, so cloning can be done in the constructor, otherwise you could not clone a mesh sub-class. 

FYI, there is no relationship between OOP and trash creation.  Any design can create tons of short lifetime garbage with ease. This is not as bad as burying references to objects in other objects beyond when they need them, so stuff can never fall out of scope and be garbage collected.

[GameMonetize]

I'm convinced it is not possible to satisfy everyone. But I assure you we are trying hard

[max123]

16 hours ago, Deltakosh said:

Always eager to improve the engine. I will work on removing this ugly Ray.Transform

Regarding camera, the inputs are pretty well separated to me: http://doc.babylonjs.com/how_to/customizing_camera_inputs

Then each camera has a specific design (ArcRotate, Free).

 

As I said, I don't disagree with decisions made - It's just we all have our own view of what's best

[max123]

hahaha you beat me to it, @Deltakosh!

[max123]

16 hours ago, JCPalmer said:

FYI, there is no relationship between OOP and trash creation.  Any design can create tons of short lifetime garbage with ease. This is not as bad as burying references to objects in other objects beyond when they need them, so stuff can never fall out of scope and be garbage collected.

Agreed.

[Temechon]

@max123 Hey thank you for your feedback Max, it's always appreciated to have constructive comments.

About the inspector, maybe I can help ? Indeed, the inspector is HTML/CSS based and I have to say it's a real pain in the ass to create a side panel
But you can create a div and ask the inspector to be created in this specific div (described here: http://doc.babylonjs.com/how_to/debug_layer)

Let me know if you need anything, even new features

[GameMonetize]

For you@max123: https://github.com/BabylonJS/Babylon.js/commit/9824853960fc2a4be97b1acb6907244c8df9f05e

 

[jerome]

Even with expensive software products or other service Premium offers, you will never meet such a fast and dedicated free answer and fix.

Maybe, this is THE reason that you might consider about choosing BJS over ... anything else 

[max123]

You guys rock!
@Temechon, I'll give it a go