jpdev Posted January 26, 2014 Share Posted January 26, 2014 Hi everyone, After cloning the github repo for phaser and switching to dev and running the "grunt build" I noticed the following: The resulting dist/phaser.js requires SAT.js (found in examples/wip) to be included in the game as a script tag before the inclusion of phaser.js. Otherwhise phaser crashes with: Uncaught ReferenceError: SAT is not defined phaser.js:38028:26 Phaser.Physics.Arcade phaser.js:38028:26So I guess the buildscript isn't up to date? I know that 1.1.4. is under development, but I want to use it so maybe find some bugs and see if other bugs are already fixed.Is there a place (dev-documentation or something) that I missed, that would have told me I needed to include the SAT.js? Link to comment Share on other sites More sharing options...
rich Posted January 26, 2014 Share Posted January 26, 2014 I don't ever use the build files during development, so this isn't totally surprising. Most I work out of the wip folder, where each JS file is included separately and I can just append any other testing / external ones to the index.php file. When 1.1.4 reaches a stage where I need to solicit feedback then I'll do a fresh build and push that (like I did with all the recent tilemap updates). I will merge the stand-alone SAT.js into the core shortly, I just ran out of time before the weekend really and didn't want to risk leaving several commits un-pushed on my PC. Link to comment Share on other sites More sharing options...
jpdev Posted January 26, 2014 Author Share Posted January 26, 2014 Hi Rich, Thanks for clearing that up. It does make sense I guess, since the one big phaser.js file is not really debugging friendly (At least webstorm isn't too happing handling it. - it can handle, but it's not as smooth as smaller files.) Link to comment Share on other sites More sharing options...
rich Posted January 26, 2014 Share Posted January 26, 2014 I'll get it all merged in now, as I want to do some final tests before I can push 1.1.4 out. Link to comment Share on other sites More sharing options...
Heppell08 Posted January 26, 2014 Share Posted January 26, 2014 Got a date for 1.1.4 yet Rich? No rush just general question Link to comment Share on other sites More sharing options...
rich Posted January 26, 2014 Share Posted January 26, 2014 I wanted it ready for GGJ14 but failed due to sickness basically. Still not fully recovered, but getting there. There's really very little left to do, so very close! tackle 1 Link to comment Share on other sites More sharing options...
Heppell08 Posted January 26, 2014 Share Posted January 26, 2014 Ah unlucky Rich. Well get well soon and just take your time. We all know how hard you're working to push this stuff out so whenever. I've also been doing more to the github documentation. Still much more to go but the stepping stones are firmly in place now tackle 1 Link to comment Share on other sites More sharing options...
Nick Posted February 6, 2014 Share Posted February 6, 2014 I'm seeing this error when trying to upgrade to 1.1.4 today: Uncaught ReferenceError: SAT is not defined line 38959 Link to comment Share on other sites More sharing options...
jpdev Posted February 6, 2014 Author Share Posted February 6, 2014 Make sure you really have the 1.1.4 release.(On github this is now "master", rich did some clean up there). Link to comment Share on other sites More sharing options...
Nick Posted February 6, 2014 Share Posted February 6, 2014 Thanks. I got 1.1.4 from the build folder currently on master. I also tried pulling the latest via git but still had the same issue. I'll double check to be sure. Link to comment Share on other sites More sharing options...
rich Posted February 7, 2014 Share Posted February 7, 2014 Hmm it's definitely included! Simple test, but open phaser.js in a text editor and search for SAT.Response and you should find all the definitions for it. If you're trying to use it in a project that uses requireJS then you may need to edit out its UMD wrapper first. But if you're just embedding the js file standalone it should be fine. Link to comment Share on other sites More sharing options...
Nick Posted February 8, 2014 Share Posted February 8, 2014 Ah that's it. I'm using require.js. Thanks Rich. Link to comment Share on other sites More sharing options...
clark Posted February 8, 2014 Share Posted February 8, 2014 I know I am incredibly annoying....But I downloaded the latest Phaser (A complete newbie) and I get this. I am using AMD, actually, I have no idea why I am using AMD, it was selected by default. I compile to a single core.js file. I am using TS 0.9.5 in Visual Studio Express 2013. Link to comment Share on other sites More sharing options...
rich Posted February 8, 2014 Share Posted February 8, 2014 Clark - could you try this definitions file instead please (just replace the one you have with this build): https://github.com/photonstorm/phaser/raw/dev/build/phaser.d.ts clark 1 Link to comment Share on other sites More sharing options...
clark Posted February 8, 2014 Share Posted February 8, 2014 Wow that was fast, you would think we would have better things to do on a Saturday eh? I replaced it, rebuilt, and its perfect! No errors. Thanks Rich Link to comment Share on other sites More sharing options...
rich Posted February 8, 2014 Share Posted February 8, 2014 You were lucky, I had only updated that file yesterday so it was fresh in my mind Link to comment Share on other sites More sharing options...
Recommended Posts