NasimiAsl Posted June 28, 2017 Share Posted June 28, 2017 i make my mirror sample http://www.babylonjs-playground.com/#1HECPU#59 that have 2 sampler i know some changes need ( like cut out of plan side ) but that render correctly i think in mirror material we change something in main shader i try keep main shader and correct that from helper shader Quote Link to comment Share on other sites More sharing options...
NasimiAsl Posted June 28, 2017 Share Posted June 28, 2017 We need add " if(vPositionW.x >0.) discard; " this part ( need calculate plan direction ) for mirror and " if(vPositionW.x < 0.) discard; " this part ( need calculate plan direction ) for refract part to correct shader and recompile that http://www.babylonjs-playground.com/#1HECPU#60 http://www.babylonjs-playground.com/#1HECPU#62 Quote Link to comment Share on other sites More sharing options...
Dad72 Posted June 29, 2017 Author Share Posted June 29, 2017 I do not know how to reproduce your examples to correct on my PG with ground and water. You asked me for PGs and it does not seem useful to you, because the examples are with your PG, so I do not understand what I should do. Is of testing for you, in order to correct the problem in CustomMaterial ? Quote Link to comment Share on other sites More sharing options...
NasimiAsl Posted June 29, 2017 Share Posted June 29, 2017 i need find the error so i need simulate mirror material to test canera 2 and rendertarget so in this sample i see we r problem in mirror material sampler ( uniform array ) i dont know what happend in mirror material inside may beed talk with writer of this for find solution fatser Quote Link to comment Share on other sites More sharing options...
Dad72 Posted July 4, 2017 Author Share Posted July 4, 2017 @NasimiAsl Will the new PG on the CustomMaterial correct the problem here? Quote Link to comment Share on other sites More sharing options...
NasimiAsl Posted July 4, 2017 Share Posted July 4, 2017 it is not about custommaterial that is need change (or create ) mirror material i try find best (fast ) solution Quote Link to comment Share on other sites More sharing options...
Dad72 Posted July 7, 2017 Author Share Posted July 7, 2017 @NasimiAsl It would be nice if this bug was corrected for version 3.0 of Babylon before its official release which is for the 7 july. Why is it so long ? How many weeks you think you will to correct this problem ? Can not we simply add a propertie that allows to recompile the shader after the creation of water or miror... ? Which should solve this problem. You may have another solution ... It's been weeks since this bug is open, can it be resolved? The version 3.0 of Babylon be released with this major bug ? Quote Link to comment Share on other sites More sharing options...
NasimiAsl Posted July 7, 2017 Share Posted July 7, 2017 the solution most be support all shader ( with or without custommaterial ) with all uniforms that take time and maybe that change the mirror material and may be new water material Quote Link to comment Share on other sites More sharing options...
Dad72 Posted July 7, 2017 Author Share Posted July 7, 2017 I did not understand what you mean? But question was if you can fix this bug for version 3.0 of Babylon? Or make it work with a quick fix. Thanks Quote Link to comment Share on other sites More sharing options...
NasimiAsl Posted July 8, 2017 Share Posted July 8, 2017 not for this version but i need 2 week at least sorry but i don't have quick solution Quote Link to comment Share on other sites More sharing options...
Dad72 Posted July 20, 2017 Author Share Posted July 20, 2017 On 08/07/2017 at 7:20 AM, NasimiAsl said: not for this version but i need 2 week at least sorry but i don't have quick solution Any news about the progress of this problem ? julien-moreau 1 Quote Link to comment Share on other sites More sharing options...
Dad72 Posted July 23, 2017 Author Share Posted July 23, 2017 @NasimiAsl Any news about the progress for this problem ? Quote Link to comment Share on other sites More sharing options...
NasimiAsl Posted July 23, 2017 Share Posted July 23, 2017 2 problem for know "replace mirrormaterial with render target" and add "add discard after mirror plan" Quote Link to comment Share on other sites More sharing options...
Dad72 Posted July 23, 2017 Author Share Posted July 23, 2017 That means what? That I have to change water material, or that you try to solve this 2 problems? Quote Link to comment Share on other sites More sharing options...
NasimiAsl Posted July 23, 2017 Share Posted July 23, 2017 i try solve that let me try 2 days if i can't you try with other solution Dad72 1 Quote Link to comment Share on other sites More sharing options...
NasimiAsl Posted July 25, 2017 Share Posted July 25, 2017 @Dad72 i can't fix it yet sorry but i know Base problem happen in MirrorTexture when you have more than default samplers Quote Link to comment Share on other sites More sharing options...
Dad72 Posted July 25, 2017 Author Share Posted July 25, 2017 I hope you will get there. I need water on my next project with refraction and reflection. Quote Link to comment Share on other sites More sharing options...
Dad72 Posted July 28, 2017 Author Share Posted July 28, 2017 I do not know why, but it seems to work now. I think the previous fix resolved this problem at the same time. http://www.babylonjs-playground.com/#ICIAGK#11 Quote Link to comment Share on other sites More sharing options...
Dad72 Posted July 30, 2017 Author Share Posted July 30, 2017 @NasimiAsl Just to try to understand, you said you could not fix this bug, but by taking over the previous PGs, it works now, so it's fix. What can not you fix? Maybe you are trying to fix another bug. Quote Link to comment Share on other sites More sharing options...
NasimiAsl Posted July 31, 2017 Share Posted July 31, 2017 " MirrorTexture when you have more than default samplers" i cant fix this bug Quote Link to comment Share on other sites More sharing options...
Dad72 Posted July 31, 2017 Author Share Posted July 31, 2017 That seems to work now. No ? Quote Link to comment Share on other sites More sharing options...
NasimiAsl Posted August 5, 2017 Share Posted August 5, 2017 not fixed yet try to see https://www.babylonjs-playground.com/#1SLLOJ#305 Quote Link to comment Share on other sites More sharing options...
Aerion Posted August 5, 2017 Share Posted August 5, 2017 I LOVE this! I don't see anything wrong with it but it would be LOVELY if when the camera is "under water" there could be a "fish eye" effect & "under water" fog! <3 Mythros Quote Link to comment Share on other sites More sharing options...
Dad72 Posted August 5, 2017 Author Share Posted August 5, 2017 5 hours ago, NasimiAsl said: not fixed yet try to see https://www.babylonjs-playground.com/#1SLLOJ#305 It's good for me @NasimiAsl (reflexion and refraction ok) Quote Link to comment Share on other sites More sharing options...
NasimiAsl Posted August 5, 2017 Share Posted August 5, 2017 but don't show the current material correctly Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.