Kesshi Posted July 19, 2016 Share Posted July 19, 2016 I just solved a bug in my app and the reason for the bug was, that i was expecting Matrix.invert() to return an inverted copy of the matrix but the matrix itself gets modified. This is a bit confusing because most other functions return a copy. For example Vector3.negate() returns a copy ... but Vector3.normalize() does not. I think a function should always return a copy here. The "InPlace" version should be added for direct modification. But i think because of compatibility this can't be changed. Maybe all those special cases should be documented (Intellisense). At the moment i always need to look at the sources to make sure that i use the functions correctly. Quote Link to comment Share on other sites More sharing options...
adam Posted July 19, 2016 Share Posted July 19, 2016 are you using typescript? Quote Link to comment Share on other sites More sharing options...
Kesshi Posted July 19, 2016 Author Share Posted July 19, 2016 10 minutes ago, adam said: are you using typescript? yes Quote Link to comment Share on other sites More sharing options...
adam Posted July 19, 2016 Share Posted July 19, 2016 I just reviewed the Math class. You make a good point. Quote Link to comment Share on other sites More sharing options...
GameMonetize Posted July 19, 2016 Share Posted July 19, 2016 Yeah I know I should have call it invertInPlace.... Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.