a question for animation in babylon source code

[Peter]

Hi

 

i just read the source code of babylon  for animation part (for learning engine dev)

 

for testing  "BABYLON.Animation.prototype.animate function" by using  https://github.com/BabylonJS/Babylon.js/wiki/07-Animation example

 

the example  frame number is range from 0-100

 

 but in looping mode that "animate" function i use console.log(currentFrame) print out the value ,the value always range from 0 ~ 99 (integer part) and lost last frame(100).

 

is this a bug?

 

 

 thanks 

 best regard

 

Peter

 

 

 

 

 

 

[GameMonetize]

Hello where do you set your console.log ?

[Peter]

Hi

 

just like this

..........................

 

        // Compute value

        var repeatCount = (ratio / range) >> 0;

        var currentFrame = returnValue ? (from + ratio % range) : to;

        console.log( (currentFrame));   // i put here.....................

 

        var currentValue = this._interpolate(currentFrame, repeatCount, this.loopMode, offsetValue, highLimitValue);

 

........................

 is this correct method to do?

 

thanks

Peter

[GameMonetize]

Yes:)

 

We drop the last frame (from my memory^^) because we interpolate from n to n +1

[Peter]

ok 

 

best regard

thank you

[GameMonetize]

My pleasure:)