particleSystem autoStart (PR suggestion)

[DigiHz Data]

It seams that all particleSystems in a .babylon scene file is automaticly started.

 

ParticleSystem.Parse = function (parsedParticleSystem, scene, rootUrl) {

.....

particleSystem.start();

.......

};

 

This is great, BUT.....sometimes we do NOT want all the particleSystems to start when the scene loads!

So we should add an option to the particleSystem:

In function ParticleSystem(name, capacity, scene, customEffect) {

.....

this.autoStart = true;

.....

}

(true as default value, but the user can set this to false and then this particleSystem will not start when the scene is loaded, the user want to start this particleSystem manually later in his code.)

 

In ParticleSystem.prototype.serialize = function () {

.....

serializationObject.autoStart = this.autoStart;

......

};

 

In ParticleSystem.Parse = function (parsedParticleSystem, scene, rootUrl) {

....

particleSystem.autoStart = parsedParticleSystem.autoStart;

if (particleSystem.autoStart){

    particleSystem.start();

}

.....

};

[Temechon]

I think it's a great idea ! Do you mind creating a PR about it ? 

[Wingnut]

Ignore/delete my post, here.  I thought I had an easier answer, but then I woke up and noticed that the topic was about particle systems that are instantiated by .babylon file imports.  At first, I thought we were talking about local particle systems.  Sorry.

I WAS thinking...  hey... http://playground.babylonjs.com/?12 ... just include/discard line 68 for full control.  But noooo...  Wingnut, that's not the subject.  (Wingnut runs for more coffee and some duct tape for his mouth.) 

[DigiHz Data]

Temechon:

I do not know how to actually do a PR. I am nt a member on github. But hopefully RaananW  or Deltakosh will do a proper PR about this.

Wingnut:

Yes you missed the whole idea

ALL particleSystems autostart from a .babylon scen file when we load it!

That is not allways what we want. Maybe we have 3 particleSystems in the scene, but we only want 1 of them to autostart when the scene loads, the other two we want to start manuall in the code.

[Temechon]

Maybe this tutorial can help you create your first PR  http://pixelcodr.com/tutos/contribute/contribute.html

 

[DigiHz Data]

Thank you Temechon, i check that link a bit deeper when i get time.

[DigiHz Data]

RaananW  or Deltakosh have anything to say about this?

[RaananW]

To prevent breaking changes I would have introduced a "preventAutoStart" variable. Then if it is set the parse method won't start the system. This way we don't need to change all previous scene files to oxide auto start.

But I like it a lot! I can do that later today.

[DigiHz Data]

hello RaananW.

Well, i do think twice before i do any suggestions here, and when i do my suggestions, i try to benefit all of us users of BJS.

"preventAutoStart" sounds good to me.

Thank you.

[MackeyK24]

FYI... preventAutoStart works great... If you are using the Current BabylonExporter.Entititesyou will need to add it to the .cs class. Or wait for the PR that exposes preventAutoStart to the external exporters like 3ds max and unity3d