DigiHz Data Posted March 30, 2016 Share Posted March 30, 2016 When serializing scene, the name of the lensFlareSystem is not serialized. "lensFlareSystems":[{"emitterId":"camera_1","borderLimit":1,"flares":[]},{"emitterId":"mesh_5","borderLimit":"10","flares":[]}], I use babylon 2.3.max Quote Link to comment Share on other sites More sharing options...
RaananW Posted March 30, 2016 Share Posted March 30, 2016 Will be soon taken care of, PR is already published (https://github.com/BabylonJS/Babylon.js/pull/1071) Quote Link to comment Share on other sites More sharing options...
DigiHz Data Posted March 31, 2016 Author Share Posted March 31, 2016 Thank you RaananW I also posted a (PR) for adding atrribute id to the LensFlareSystem. Question....When suggesting a PR........how and when will we know if it has been approved or not? Quote Link to comment Share on other sites More sharing options...
RaananW Posted March 31, 2016 Share Posted March 31, 2016 I don't see any PR from you, so it was either already merged, or you submitted is only in your fork. Once we review it, we simply merge and you are notified by github. Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.