JCPalmer Posted February 8, 2016 Share Posted February 8, 2016 Now that all cameras, except Camera of course, inherit from TargetCamera, perhaps a clean up is in order for 2.4. In the past ArcRotateCamera was directly from Camera. Now it is TargetCamera. Do not think it will be missed. Quote Link to comment Share on other sites More sharing options...
GameMonetize Posted February 9, 2016 Share Posted February 9, 2016 No problem for me> I can do it if you want Quote Link to comment Share on other sites More sharing options...
JCPalmer Posted February 9, 2016 Author Share Posted February 9, 2016 Go for it. I have higher priorities, so it would be a while before I did it. Was just checking where universal inherited from, & noticed this. Early in alpha a good time for this kind of stuff. Quote Link to comment Share on other sites More sharing options...
GameMonetize Posted February 9, 2016 Share Posted February 9, 2016 Actually I thought about it twice and I do not see a real value to remove it. It helps having smaller classes (think about mesh class). Camera is fat enough And who knows, perhaps we may find a kind of camera without a target (Ok I doubt about it :)) Is there a problem on your side this merge could fix? Quote Link to comment Share on other sites More sharing options...
JCPalmer Posted February 9, 2016 Author Share Posted February 9, 2016 None. My problem / bias against TargetCamera was when ArcRotateCamera did not inherit from it (against ArcRotateCamera really). Made refactoring 3D rigging directly into Camera & getting rid of most of those VR cameras more difficult. Brought it up, just so leaving it alone was an active decision. As repository grows, things can get more and more layered. Not always a good thing. Quote Link to comment Share on other sites More sharing options...
GameMonetize Posted February 9, 2016 Share Posted February 9, 2016 I tend to agree but here this is more fore readability Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.