Forum Upgraded

[WombatTurkey]

@rich

Is it possible to enable a post preview button?

[staff0rd]

This may seem pedantic, but I think it's pretty lame that the Website Url under a profile's contact methods are is a <span> rather than an <a> meaning you navigate with it.

[BdR]

On 12-1-2016 at 2:48 PM, rich said:

No-one ever likes change. Ever. Least of all on the internets.

I've been active on a few forums, and with these change/update moments people always(!) complain about the layout changes.  A major update like this at least shows the community is still alive and I assume/hope the update will make the forum easier to manage for the people who are running it, so more power to you and all that good stuff.

The only downside for now is that older posts are missing linefeeds in the code blocks (some users already mentioned this) makes them look messy and hard to read. I hope this can be fixed in due time, because the forum has accumulated a lot of valuable tips and tricks with example code.

[staff0rd]

2 minutes ago, BdR said:

The only downside for now is that the code blocks with missing CRLF look messy and harder to read. I hope this can be fixed in due time, because over the forum has accumulated a lot tips and tricks with example code.

That is a problem, all these great examples are now difficult to read.

[GaryS]

Agreed... As a complete N00b, googling every little thing I need to know and usually finding answers on this forum; I find the lack of carriage returns in the code snippets infuriating!!

Otherwise, the forum's kinda nice.

[GaryS]

Hmm... looks like new code snippets aren't coloured either...

[Antriel]

Hmm, maybe Rich could query the post database, extract the code tags, run content through some beautifier and replace the original with now beautiful code

[staff0rd]

Strangely this post has the first two code samples with broken line endings, but the last one appears fine.

[rich]

10 hours ago, staff0rd said:

Strangely this post has the first two code samples with broken line endings, but the last one appears fine.

There's nothing I can do about that. The forum conversion process when it 'upgraded' from 3 to 4 screwed all of the line-endings. It's impossible to go back through and fix it.

[staff0rd]

7 hours ago, rich said:

There's nothing I can do about that. The forum conversion process when it 'upgraded' from 3 to 4 screwed all of the line-endings. It's impossible to go back through and fix it.

That's pretty unfortunate - it lowers the readability of the code considerably, and most of my google searches land me right in these forums.

Here's a proposition - does the forum have any kind of permissions that can be granted to certain users that would allow them to edit other users's posts?  If so, perhaps you could get volunteers to fix these line endings manually?  I would certainly offer to help, as this forum is the main resource for me to learn phaser, and I'd at least fix every post I land on from google that has broken line endings.  Fixing such issues would likely improve my memory retention of the framework also.

[staff0rd]

Also I might add that it looks like for at least some posts, like this one, a little jquery bookmarklet that will switch whitespace for linebreaks/tabs would greatly help the aforementioned proposition.

[chg]

Lovely quirk of the new code editor...

var v = vertices;

vs.

var v = vertices[ i ];

these lines differ by the white space around "i" (which is in square brackets), but without the whitespace some of the code disappears (the open square bracket, the i and the close square bracket) which I presume has something loosely to do with this sequence having meaning in BBcode source.

I suggest it's an issue as i is like the most common iterator for loops and it is not unreasonable to expect it to will be used to index arrays often in posted code

[Sebi]

Hey Rick,

is there a way to 1. preview posts and 2. to disable the wysiwyg editor?

I can't find those options anymore. 

 

I would also be happy if there is a way to reduce the lineHeight for messages.

This kinda gives the facebook vibe. No double checking, type it and send it, feels so spammy xD

[rich]

There aren't any options for either of those things in the admin, so nope.

[chg]

@rich Any comment on open square bracket, letter i, close square bracket disappearing from code posted

[rich]

Nope, it obviously thinks it is bbcode for some reason. There is no way to turn bbcode off, so I guess we're stuck with it until they fix it.

[GaryS]

Just a thought - presumably the code is stored in the database with its various carriage returns and such - and presumably the issue is that the forum software isn't recognizing them as it should.

I'd expect that this issue is fairly consistant across the data, so it might be possible with a big of RegEx and SQL magic to convert the old format to the new format.

I'm happy to give it a try if you can send me a couple of samples of new and old post records?

I have to say, as a very new Phaser developer (Loving Phaser... love love love!), I'm finding myself Googling constantly, and hitting these old style formatting issues every time. It makes it pretty much unreadable and due to comments and such, the JS beautifiers aren't much help.

It's an absolute shedload of content that really isn't fulfilling its potential at the moment!

[staff0rd]

If that were the case it would probably be cleaner just to turn off the server-side code snippet formatting, just render them inside <pre> tags and then use prettify do its work client-side. 

[GaryS]

Oh wow... I've just looked at the code for the codeblocks... everything is in a <span>. I can't tell if there are carriage returns in the data, but if the database has the content saved with the span formatting, that could be pretty difficult to do anything with.

 

[rich]

I looked in the database at some of the old posts with code in. The code is wrapped with a <pre> tag. Looks like this:

<pre class="ipsCode prettyprint">betterUpdateBounds: function() {        this.width = this.sprite.width;        this.height = this.sprite.height;        this.halfWidth = Math.floor(this.width / 2);        this.halfHeight = Math.floor(this.height / 2);        this.center.setTo(this.x + this.halfWidth, this.y + this.halfHeight);        //this.offset.x = (this.sprite.anchor.x * this.width);        //this.offset.y = (this.sprite.anchor.y * this.height);}</pre>

An here's a gist because the forum will no doubt screw the above up: https://gist.github.com/photonstorm/50d6a94aba9704441c7a

So I reckon we could probably get away with just using some css and the prettyprint library and not have to actually modify the database contents at all.

[rich]

Well that didn't work

Still at least there is a way to identify the rogue code.

I've done a SQL dump of just the posts table, will upload it if anyone wants to have a go at writing a SQL script to fix it up.

[chg]

Is that the post table data post migration scripts, if so do you have a before version?

I had a look at the text in a hexeditor... there's no indication of newlines in there, though I did find the mix of space characters with multi-byte sequences for non-breaking spaces interesting (to use the term loosely)

[GaryS]

I'd have to assume copying and pasting it up to a gist will mess with any line breaks that may be in there. If there's a raw copy of the SQL you can zip and upload I'll certainly give it a shot... No promises, but y'know, I've had to squangle this kind of stuff before.

What OS is the database server running?

 

[staff0rd]

3 hours ago, rich said:

I've done a SQL dump of just the posts table, will upload it if anyone wants to have a go at writing a SQL script to fix it up.

Please upload.

[rich]

Here: http://gametest.mobi/html5gamedevs-posts.7z

It's the new posts table and the original one. When the forum upgraded it automatically converted from the original format to the new one, but the data still remains.

Feel free to see what you can do with this - I will need a SQL script (or php script is ok) back from anyone who wants to take this on, as obviously sending me the SQL back is useless.