Blax Posted December 7, 2015 Share Posted December 7, 2015 Hi! I found small bug in serializer.It crash, if i try serialize scene with ShaderMaterial's. Uncaught TypeError: Cannot read property 'asArray' of undefinedserializeMaterial @ babylon.max.js:24503SceneSerializer.Serialize @ babylon.max.js:25000 ambientColor and etc property's is not present in ShaderMaterial's. I think we need one 'if' there, who exclude all shaderMaterials from srialize process. Quote Link to comment Share on other sites More sharing options...
RaananW Posted December 7, 2015 Share Posted December 7, 2015 let me check that.A fix will come soon after :-) Quote Link to comment Share on other sites More sharing options...
RaananW Posted December 7, 2015 Share Posted December 7, 2015 Well, I found a different problem with the serialization, but what you refer to should not happen since 2.3. What version are you using?The Shader's serialize function is not yet implemented, so the material won't serialize (not more than an ID). I will prevent it for now from happening, so there wouldn't be any "naked" materials with no content. Quote Link to comment Share on other sites More sharing options...
Blax Posted December 8, 2015 Author Share Posted December 8, 2015 Well, I found a different problem with the serialization, but what you refer to should not happen since 2.3. What version are you using?The Shader's serialize function is not yet implemented, so the material won't serialize (not more than an ID). I will prevent it for now from happening, so there wouldn't be any "naked" materials with no content. Hi!I use 2.2 (i can't use 2.3. because get trouble with ArcRotateCamera). Bug is small and not is big problem And yes, not necessary save naked material only with id, it only create excess test on loading. Hope eventually we can use and custom shaders serializer ) Thank for fixes!!! Quote Link to comment Share on other sites More sharing options...
RaananW Posted December 8, 2015 Share Posted December 8, 2015 And now you can :-) I pushed a commit yesterday with shader material serialization and parsing. Should work with 2.3 as of... yesterday.You will still need to provide your shaders, just like with regular shader material initialization. The serializer just takes your shader path definitions and export it. Quote Link to comment Share on other sites More sharing options...
Blax Posted December 10, 2015 Author Share Posted December 10, 2015 WOW! It speed of light! I'm will test this. Really great! Thank! Quote Link to comment Share on other sites More sharing options...
RaananW Posted December 10, 2015 Share Posted December 10, 2015 That's what we are all about! Speed of light bug fixing for speed-of-60-FPS framework!We like challenges here Let us know if it is working! GameMonetize 1 Quote Link to comment Share on other sites More sharing options...
Blax Posted December 16, 2015 Author Share Posted December 16, 2015 Sorry for silent. I get alpha 2.3, but bug still stay Babylon.js /dist/ preview release - alpha / babylon.2.3.max.js How branch must use? Quote Link to comment Share on other sites More sharing options...
RaananW Posted December 16, 2015 Share Posted December 16, 2015 Should be in the master. Can you try reproducing in the playground? would be easier for me to debug Quote Link to comment Share on other sites More sharing options...
Blax Posted December 17, 2015 Author Share Posted December 17, 2015 i get https://github.com/BabylonJS/Babylon.js/blob/master/dist/babylon.2.2.max.js (3 month ago....)? I think i get not fresh version... What file i must get? Say me link please p.s. generate show with shader and error in playground is not simple (13k code + textures). Probably i get wrong file. Quote Link to comment Share on other sites More sharing options...
RaananW Posted December 17, 2015 Share Posted December 17, 2015 You will need to use the latest 2.3. Download it from github or use the playground to test it out Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.