ParticleSystem serialize problem

[MasterK]

1.  these two is missing... both in serialize and parse.

particle.minEmitPower
particle.maxEmitPower

 

2. if i dont have an object emitter but only set a position emitter, 

in serialize:

serializationObject.emitterId = this.emitter.id; //(it will be null).

and in parse:

var emitter = scene.getLastMeshByID(parsedParticleSystem.emitterId); //(null...)

var particleSystem = new ParticleSystem("particles#" + emitter.name, parsedParticleSystem.capacity, scene);

 

problem is emitter.name will be error.

 

 

[MasterK]

another bug...

particleSystem.targetStopDuration = parsedParticleSystem.targetStopFrame; // should be targetStopDuration;

[Temechon]

Hi, 

 

Thank you for your feedback It's fixed and waiting for approval! https://github.com/BabylonJS/Babylon.js/pull/857

[MasterK]

Hi, 

 

Thank you for your feedback It's fixed and waiting for approval! https://github.com/BabylonJS/Babylon.js/pull/857

 

if (this.emitter.position) {

worldMatrix = this.emitter.getWorldMatrix();

}

else {

worldMatrix = BABYLON.Matrix.Translation(this.emitter.x, this.emitter.y, this.emitter.z);

}

 

i think both serialize and parse should support emitter like this.

 

and .name can be export and import... to instead of '"particles#" + emitter.name'.

[MasterK]

i make a first pull request in my life... don't know is it ok.

[Temechon]

Sounds good ! I think there is a little typo, could you please fix it ? Otherwise it's perfect !

[MasterK]

i see your comment!! nice boy. haha. github is good thing.

i fixed it.

[Temechon]

Yeah ! The nice boy is merging

 

Thank !

[MasterK]

after the merging, your changing is lost...

why?

 

the minEmitPower and maxEmitPower and targetStopFrame

[Temechon]

My changes are in the main repo : https://github.com/BabylonJS/Babylon.js/blob/master/src/Particles/babylon.particleSystem.ts#L507

[MasterK]

lost in .js file...

isee, u just fixed in ts...