Dad72 Posted September 26, 2015 Share Posted September 26, 2015 Hello, the workerCollision does not support instances. instanced objects have disappeared. http://www.babylonjs-playground.com/#27MEGQ Quote Link to comment Share on other sites More sharing options...
RaananW Posted September 27, 2015 Share Posted September 27, 2015 ah, I was pretty sure this was repaired already (was a problem in 2.1 beta). let me check and get back to you. Quote Link to comment Share on other sites More sharing options...
RaananW Posted September 27, 2015 Share Posted September 27, 2015 Ok, Problem found. I will work on a clean solution. Was much simpler than I thought, https://github.com/BabylonJS/Babylon.js/pull/705 . This is one of those head-scratching bugs where you actually wonder "how the heck did it work before?". Should be fine by the next update of the playground, would be great if you updated here if it worked or not. Quote Link to comment Share on other sites More sharing options...
Dad72 Posted September 28, 2015 Author Share Posted September 28, 2015 Should be fine by the next update of the playground, would be great if you updated here if it worked or not. Ok. Thank you RaananW Quote Link to comment Share on other sites More sharing options...
GameMonetize Posted September 28, 2015 Share Posted September 28, 2015 Playground updated Quote Link to comment Share on other sites More sharing options...
Dad72 Posted September 28, 2015 Author Share Posted September 28, 2015 Thanks DK. Bug fixed RaananW. http://www.babylonjs-playground.com/#27MEGQ#1 RaananW 1 Quote Link to comment Share on other sites More sharing options...
Ahiru Posted September 28, 2015 Share Posted September 28, 2015 With me it still does not work - let me guess - I still get the old version of the playground again by my ISP?? How can I see what version is in use? Quote Link to comment Share on other sites More sharing options...
GameMonetize Posted September 28, 2015 Share Posted September 28, 2015 I'm afraid yes can you force a refresh? Quote Link to comment Share on other sites More sharing options...
GameMonetize Posted September 28, 2015 Share Posted September 28, 2015 To get the current version: http://www.babylonjs-playground.com/#1MGLPT Quote Link to comment Share on other sites More sharing options...
Dad72 Posted September 28, 2015 Author Share Posted September 28, 2015 still get the old version of the playground again by my ISP I think yes. How can I see what version is in use? with debugLayer. but it does not specifically give the revision numbers, just so it's version 2.3. It should something like: version 2.3 update xx What do you think DK have a version number but also a revision of numbers in a version? Quote Link to comment Share on other sites More sharing options...
GameMonetize Posted September 28, 2015 Share Posted September 28, 2015 Yes this is a good idea but there is a trick: I have to think about increasing it each time Quote Link to comment Share on other sites More sharing options...
Dad72 Posted September 28, 2015 Author Share Posted September 28, 2015 Yes, Where you have to create an auto increment system you add an update. GameMonetize 1 Quote Link to comment Share on other sites More sharing options...
Ahiru Posted September 28, 2015 Share Posted September 28, 2015 Ok, works now - guess with a new number behind it's refreshed - the Cache of the ISP (Internet-Service-Provider) can't be refreshed from us customers. When I code online, I always have to change the name of my scripts to see the new versions, otherwise I'll always get delivered the old version. Quote Link to comment Share on other sites More sharing options...
Dad72 Posted September 29, 2015 Author Share Posted September 29, 2015 Wow, the WorkerCollision create a greater optimization when using collision with a character that walks on terrain.On my scene with 35 FPS I returned to 60 FPS through WorkerCollision activate. Quote Link to comment Share on other sites More sharing options...
RaananW Posted September 29, 2015 Share Posted September 29, 2015 That's exactly what it was meant to do :-) Gotta love workers! Just note that the collision still runs a bit slower than 60 FPS, so you still have animations and other things in the scene running in 60 FPS, but the camera might still move as if it is in 40 FPS. Quote Link to comment Share on other sites More sharing options...
Dad72 Posted September 29, 2015 Author Share Posted September 29, 2015 Hi Raanan, I find another small problem with WorkerCollision. When you mesh.dispose() an object, the collision is still calculated even if the object is no longer present. Quote Link to comment Share on other sites More sharing options...
RaananW Posted September 29, 2015 Share Posted September 29, 2015 Wow!Thanks! you are totally right! It is all prepared, but missing the final "remove" implementation in the worker. Will work on that. Quote Link to comment Share on other sites More sharing options...
RaananW Posted September 29, 2015 Share Posted September 29, 2015 PR pushed, please let me know if it works after the next update. And keep on reporting bugs :-) Quote Link to comment Share on other sites More sharing options...
Dad72 Posted September 29, 2015 Author Share Posted September 29, 2015 No problem.I test everything, and I report if I see a small problem. Thanks Raanan Quote Link to comment Share on other sites More sharing options...
RaananW Posted September 29, 2015 Share Posted September 29, 2015 just pushed a small correction, waiting for DK. Quote Link to comment Share on other sites More sharing options...
GameMonetize Posted September 29, 2015 Share Posted September 29, 2015 Everything validated That's fun because I now spend more time validating PR than coding and this is great because this means we have a really community driven OSS project! Dad72, reddozen and RaananW 3 Quote Link to comment Share on other sites More sharing options...
Dad72 Posted September 29, 2015 Author Share Posted September 29, 2015 I can not yet test because we need the babylon.min.js file is created. Quote Link to comment Share on other sites More sharing options...
Dad72 Posted September 30, 2015 Author Share Posted September 30, 2015 Deltakosh it would be possible to generate minimize (in dist/preview release/) the file with the patch RaananW I can test and tell her if it's ok. Thank you. Quote Link to comment Share on other sites More sharing options...
GameMonetize Posted September 30, 2015 Share Posted September 30, 2015 Will do today Quote Link to comment Share on other sites More sharing options...
Dad72 Posted September 30, 2015 Author Share Posted September 30, 2015 After testing it's perfect, it works well. Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.