Mesh Rotation Bug

[ChrisR]

So while i have been messing around with rotating objects, i came across a small bug in the babylonjs file.

 

Under Mesh.rotate:

 

If the space is in World space, and it has a parent, the code looks like:

                if (this.parent) {                    var invertParentWorldMatrix = this.parent.getWorldMatrix().clone();                    invertParentWorldMatrix.invert();                    axis = Vector3.TransformNormal(axis, invertParentWorldMatrix);                }

This causes the mesh to grow exponentially in size as its being rotated.

 

Simple fix add axis.normalize() to the end: So

               if (this.parent) {                    var invertParentWorldMatrix = this.parent.getWorldMatrix().clone();                    invertParentWorldMatrix.invert();                    axis = Vector3.TransformNormal(axis, invertParentWorldMatrix);                    axis.normalize();                }

I'm sure to whomever updates the babylon files this will make sence to normalize the axis before applying it to rotate.

 

Or maybe you would prefer it in Math.RotationAxis to normalize the axis before use as a better precaution?

[GameMonetize]

I like the Math.RotationAxis fix better

 

Do you mind sending a PR to get credits for your fix? (and do not forget to update https://github.com/BabylonJS/Babylon.js/blob/master/dist/preview%20release/what's%20new.md) 

[ChrisR]

Yea, i mentioned before doing PR and Git related activities confuse me. However i have always wanted to learn. Maybe i will spend the next few hours getting aquatined. 

[GameMonetize]

No worry I would be please to do the fix for you and add your name as the developer (But I think it worth learning how to use git)

[ChrisR]

Thanks and I will learn it

[ChrisR]

Created a pull request. I believe i have things figured out now on git  

[GameMonetize]

well done!