lineBitmapStyle, lineGradientStyle, beginGradientFill, beginBitmapFill

[FlorianLudwig]

Hi,

 

there is some missing functionality in PIXI.Graphics that I would like to add:

• lineBitmapStyle(bitmap:BitmapData, matrix:Matrix = null, repeat:Boolean = true)
• lineGradientStyle(type:String, colors:Array, alphas:Array, ratios:Array, matrix:Matrix = null)
• beginGradientFill(type:String, colors:Array, alphas:Array, ratios:Array, matrix:Matrix = null)
• beginBitmapFill(bitmap:BitmapData, matrix:Matrix = null, repeat:Boolean = true)

 

as present in the flash api.

 

First two patches:

• implement lineBitmapStyle for canvas renderer
• support lineBitmapStyle matrix
• The rest of the api and WebGL renderer will follow.

 

Would there be interest to merged these (when done) into PIXI?

 

Feedback on API and implementation are welcome!

 

 

[xerver]

Development of pixi is done on github:

 

https://github.com/GoodBoyDigital/pixi.js

 

Feel free to put in a PR anytime. If we were to merge it, it would likely be for v3 (dev branch).

[FlorianLudwig]

Hey xerver,

 

i was looking for some feedback on the plan and implementation before continuing and going to do a PR.

 

Btw i worked against the dev branch so the posted patches are for v3 already.

[xerver]

A PR is the best way to get feeback on implementation. Most people who work on pixi including myself and Mat rarely come here.

[FlorianLudwig]

I created an issue on github:

 

https://github.com/GoodBoyDigital/pixi.js/issues/1567

 

PR will follow as soon as the WebGL part is done.