jerome Posted February 9, 2015 Author Share Posted February 9, 2015 Thank youYou are very clear I am on linux and use SublimeText. I just added the references so the editor could autocomplete. It is just confort, I can delete them.I will use gulp as you suggest and not tsc.I'll test ... wednesday, now. Quote Link to comment Share on other sites More sharing options...
jerome Posted February 16, 2015 Author Share Posted February 16, 2015 Mesh.CreateRibbon() PRed iiceman 1 Quote Link to comment Share on other sites More sharing options...
GameMonetize Posted February 17, 2015 Share Posted February 17, 2015 Validated but with comments Quote Link to comment Share on other sites More sharing options...
GameMonetize Posted February 17, 2015 Share Posted February 17, 2015 And now you need to update this doc:http://doc.babylonjs.com/page.php?p=22011 If you can update the playground as well (Send me the a new save and I will update for you the Playground Demo Scene 02) Welcome on board!!! Quote Link to comment Share on other sites More sharing options...
jerome Posted February 17, 2015 Author Share Posted February 17, 2015 thank you aarg...I sent an unfinished documentation edition... "edit proposition succesfully sent"Can't get back to complete it Do I need to wait for a curator to validate it before I can continue ? suggestion for doc editor :have a save button (or a visible auto-save process) in the sessionanda different submit to curator or validate button Quote Link to comment Share on other sites More sharing options...
jerome Posted February 17, 2015 Author Share Posted February 17, 2015 I tried to update the playground scene : http://www.babylonjs-playground.com/#1UACTAbut I think the playground running engine BJS version doesn't implement the ribbon yet...so I can't finalize it to adjust the ribbon size to the other basic shapes shown in the example Quote Link to comment Share on other sites More sharing options...
jerome Posted February 17, 2015 Author Share Posted February 17, 2015 @DKI refactored the method with strong typing for each used variable and fixed the scope too.Not sure about how to PR again on this first PR : https://github.com/jbousquie/Babylon.js/compare/feature.createRibbon?expand=1 Quote Link to comment Share on other sites More sharing options...
jerome Posted February 17, 2015 Author Share Posted February 17, 2015 Ok, RaananW explained me many things. Thanks to him Sorry for this PR, it wasn't on a new dedicated branch, but the same former one.Next time I'll do cleaner. Still fighting with git/github and Eclipse+palantir (just gave up TypEsc plugin : no doc, no wiki) : still can't understand why it protests on some var keywords and not on others ("the word var is not correctly spelled"... if you know, palantir users ?). Very strange ... If someone knows a pertinent link with how to set up Eclipse/palantir for TS or even BJS, he/she 's welcome Else I will probably go back to old good SublimeText+TS3 plugin + gulp Quote Link to comment Share on other sites More sharing options...
JCPalmer Posted February 17, 2015 Share Posted February 17, 2015 One thing I noticed with the Planantir plugin an is old error sometimes still has the red underline left as an artifact. May not be the case for spelling var, but I do a text select, it forces a re-draw. I have solved "errors" that no longer existed before. As far as Git/github: I cloned my local repository from my github fork like GitHub says to https://help.github.com/articles/fork-a-repo/. I have Unbuntu, so I installed command line git. Added my "upstream" remote from the command line. I do all other git stuff in Eclipse, by right clicking in the "Project Explorer" & using the "Team" sub menu. Note some stuff, like "Merging" are only available when right clicking over the Project folder. I have had no luck doing "Team" -> "Fetch from Upstream". To get an update I do "Team" -> "Remote" -> "Fetch From...". I then pick the "Upstream remote". I then do a "Team" -> "Merge". I always do a push to my fork as a separate operation from the last commit (I have done this with the Extensions repository though, but I did not fork that one). I push to my BabylonJS fork using "Team" -> "Push Branch..." jerome 1 Quote Link to comment Share on other sites More sharing options...
GameMonetize Posted February 17, 2015 Share Posted February 17, 2015 That's great! I saw that you updated the doc which is great as well:) can you just update this demo too:http://www.babylonjs-playground.com/#LCH8C Quote Link to comment Share on other sites More sharing options...
jerome Posted February 17, 2015 Author Share Posted February 17, 2015 okdoc not finished because.. well, bad clickI'll go on tomorrow I wanted to update the playground today but the CreateRibbon() method wasn't yet know by the engine (maybe the build was done before the PR merge ?)I'll do it tomorrow also. Quote Link to comment Share on other sites More sharing options...
GameMonetize Posted February 17, 2015 Share Posted February 17, 2015 it is here (but not on the intelisense) Quote Link to comment Share on other sites More sharing options...
jerome Posted February 18, 2015 Author Share Posted February 18, 2015 Just a suggestion about the doc : Wouldn't it be worth it to create a new dedicated page (or sub-page) to parametric shapes ?The ribbon, for example, has no initial expected shape while you can expect a box to be cubic, a sphere to be spherical, etc.I will put a ribbon example on the demo playground of course but it will just be a very particular application. I think having an extra-page for new parametric shapes to come would be nice as we could explain accurately to users how to deal with these parameters. Quote Link to comment Share on other sites More sharing options...
jerome Posted February 18, 2015 Author Share Posted February 18, 2015 @DK : here's the ribbon now integrated in the playground demo http://www.babylonjs-playground.com/#LCH8C#2 Quote Link to comment Share on other sites More sharing options...
GameMonetize Posted February 18, 2015 Share Posted February 18, 2015 Huge!! And I'm totally fine with having a new page to dig into parametric shapes! Quote Link to comment Share on other sites More sharing options...
GameMonetize Posted February 18, 2015 Share Posted February 18, 2015 Playground updated: http://www.babylonjs-playground.com/?2 Quote Link to comment Share on other sites More sharing options...
GameMonetize Posted February 18, 2015 Share Posted February 18, 2015 @Wingnutt: Can you please update the picture here? (I see this is hosted on your server:))http://doc.babylonjs.com/page.php?p=22011 Quote Link to comment Share on other sites More sharing options...
jerome Posted February 18, 2015 Author Share Posted February 18, 2015 Cool for the playgroundAs I can see these plane meshes with no material, the sideOrientation (+doubleSide) feature could be a real plus. For the documentation, what about the API doc ?The version 1.4 is still online with 2.0 for now.No 2.1 yet. I can wait anyway. Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.